Re: [libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-10 Thread Matthias Bolte
2010/12/8 Jean-Baptiste Rouault : > --- >  cfg.mk                      |    1 + >  configure.ac                |    7 + >  include/libvirt/virterror.h |    1 + >  po/POTFILES.in              |    2 + >  src/Makefile.am             |   24 +- >  src/driver.h                |    3 +- >  src/libvirt.c

Re: [libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-09 Thread Jean-Baptiste Rouault
On Thursday 09 December 2010 11:23:38 Daniel P. Berrange wrote: > On Thu, Dec 09, 2010 at 11:05:50AM +0100, Jean-Baptiste Rouault wrote: > > On Wednesday 08 December 2010 19:29:56 Daniel P. Berrange wrote: > > > FYI, you can still get CPUs which are 32-bit only and have vmx/svm > > > supported. > >

Re: [libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-09 Thread Daniel P. Berrange
On Thu, Dec 09, 2010 at 11:05:50AM +0100, Jean-Baptiste Rouault wrote: > On Wednesday 08 December 2010 19:29:56 Daniel P. Berrange wrote: > > > > FYI, you can still get CPUs which are 32-bit only and have vmx/svm > > supported. > > Indeed, I didn't know there were 32 bits CPUs with virtualization

Re: [libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-09 Thread Jean-Baptiste Rouault
On Wednesday 08 December 2010 19:29:56 Daniel P. Berrange wrote: > > FYI, you can still get CPUs which are 32-bit only and have vmx/svm > supported. Indeed, I didn't know there were 32 bits CPUs with virtualization extensions. Would it be ok to check for the "lm" CPU flag to be certain that the h

Re: [libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-08 Thread Daniel P. Berrange
On Wed, Dec 08, 2010 at 06:55:08PM +0100, Jean-Baptiste Rouault wrote: > +virCapsPtr > +vmwareCapsInit(void) > +{ > +struct utsname utsname; > +virCapsPtr caps = NULL; > +virCapsGuestPtr guest = NULL; > +virCPUDefPtr cpu = NULL; > +union cpuData *data = NULL; > + > +uname(&u

[libvirt] [Patch v3] Add VMware Workstation and Player driver

2010-12-08 Thread Jean-Baptiste Rouault
* Changes since v2: remove unnecessary mutex locks use vmrun reset soft convert popen to virCommand remove duplicate errors various other fixes -- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list