Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 07:12 PM, Jiri Denemark wrote: > On Fri, Oct 27, 2017 at 17:18:44 +0200, Halil Pasic wrote: >> On 10/27/2017 04:06 PM, Christian Borntraeger wrote: > ... >>> I talked to several people and it seems that on x86 the host model will >>> also enable new features >>> that are not known

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Fri, Oct 27, 2017 at 17:18:44 +0200, Halil Pasic wrote: > On 10/27/2017 04:06 PM, Christian Borntraeger wrote: ... > > I talked to several people and it seems that on x86 the host model will > > also enable new features > > that are not known by older QEMUs and its considered works as

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 04:06 PM, Christian Borntraeger wrote: > > > On 10/27/2017 03:40 PM, Halil Pasic wrote: >> >> >> On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: On 10/27/2017 02:31 PM, Halil Pasic wrote: gs

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 03:40 PM, Halil Pasic wrote: > > > On 10/27/2017 02:57 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >>> >>> >>> On 10/27/2017 02:31 PM, Halil Pasic wrote: >>> gs is explicitly disabled. Now that I think about it, maybe

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 03:31 PM, Cornelia Huck wrote: > On Fri, 27 Oct 2017 14:42:57 +0200 > Christian Borntraeger wrote: > >> Yes, we should also replace that with >> >> return s390_has_feat(S390_FEAT_GUARDED_STORAGE) >> >> I can fixup my patch or provide a 2nd one. >> > >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:57 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:45 PM, Christian Borntraeger wrote: >> >> >> On 10/27/2017 02:31 PM, Halil Pasic wrote: >> gs is explicitly disabled. >>> >>> Now that I think about it, maybe the 2.9 binary is going to reject >>> the explicit gs flag

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On Fri, 27 Oct 2017 14:42:57 +0200 Christian Borntraeger wrote: > Yes, we should also replace that with > > return s390_has_feat(S390_FEAT_GUARDED_STORAGE) > > I can fixup my patch or provide a 2nd one. > Consider a fixed up patch acked by me. -- libvir-list mailing

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:45 PM, Christian Borntraeger wrote: > > > On 10/27/2017 02:31 PM, Halil Pasic wrote: > gs is explicitly disabled. >> >> Now that I think about it, maybe the 2.9 binary is going to reject >> the explicit gs flag altogether, because it's unknown. >> >> Isn't this a problem? >

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:31 PM, Halil Pasic wrote: gs is explicitly disabled. > > Now that I think about it, maybe the 2.9 binary is going to reject > the explicit gs flag altogether, because it's unknown. > > Isn't this a problem? No. This is exactly the _solution_ and not the problem. The target

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/27/2017 02:31 PM, Halil Pasic wrote: > > > On 10/25/2017 08:13 PM, Jason J. Herne wrote: >> On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >>> Starting a guest with >>>     >>> hvm >>>    >>>    >>> >>> on an IBM z14 results in >>> >>> "qemu-system-s390x: Some features

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/25/2017 08:13 PM, Jason J. Herne wrote: > On 10/20/2017 10:54 AM, Christian Borntraeger wrote: >> Starting a guest with >>     >> hvm >>    >>    >> >> on an IBM z14 results in >> >> "qemu-system-s390x: Some features requested in the CPU model are not >> available in the

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/26/2017 10:13 AM, Christian Borntraeger wrote: > > > On 10/26/2017 01:35 AM, Halil Pasic wrote: > try the most interesting scenarios out. >> >> The idea of the patch is very clear, but I don't understand the bigger gs >> feature context fully. >> >> From what I read in the code, the

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/26/2017 01:35 AM, Halil Pasic wrote: try the most interesting scenarios out. > > The idea of the patch is very clear, but I don't understand the bigger gs > feature context fully. > > From what I read in the code, the attempt to enable the gs capability in > the kernel is made

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/20/2017 04:54 PM, Christian Borntraeger wrote: > Starting a guest with > > hvm > > > > on an IBM z14 results in > > "qemu-system-s390x: Some features requested in the CPU model are not > available in the configuration: gs" > > This is because guarded storage is fenced for

Re: [libvirt] [Qemu-devel] [PATCH/QEMU] s390x/kvm: use cpu_model_available for guarded storage on compat machines

On 10/20/2017 10:54 AM, Christian Borntraeger wrote: Starting a guest with hvm on an IBM z14 results in "qemu-system-s390x: Some features requested in the CPU model are not available in the configuration: gs" This is because guarded storage is fenced for compat machines that