Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Corey Bryant
On 10/05/2012 02:51 PM, Eric Blake wrote: On 10/05/2012 12:44 PM, Corey Bryant wrote: Yes, this makes more sense. I'd like to mirror the add-fd QMP command as much as possible: { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'}, 'returns': 'AddfdInfo' } So maybe we can

Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Eric Blake
On 10/05/2012 12:44 PM, Corey Bryant wrote: > Yes, this makes more sense. I'd like to mirror the add-fd QMP command > as much as possible: > > { 'command': 'add-fd', 'data': {'*fdset-id': 'int', '*opaque': 'str'}, > 'returns': 'AddfdInfo' } > > So maybe we can make it: > > -add-fd fd=24,fdset

Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Corey Bryant
On 10/05/2012 02:25 PM, Blue Swirl wrote: On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote: These new options can be used for passing drive file descriptors on the command line, instead of using the file option to specify a file name. These new command line options mirror the existing add-

Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Corey Bryant
On 10/05/2012 02:30 PM, Eric Blake wrote: On 10/05/2012 12:25 PM, Blue Swirl wrote: On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote: These new options can be used for passing drive file descriptors on the command line, instead of using the file option to specify a file name. These new co

Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Eric Blake
On 10/05/2012 12:25 PM, Blue Swirl wrote: > On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant > wrote: >> These new options can be used for passing drive file descriptors >> on the command line, instead of using the file option to specify >> a file name. >> >> These new command line options mirror the

Re: [libvirt] [Qemu-devel] [PATCH 3/4] qemu-config: Add -drive fd and opaque options

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 6:07 PM, Corey Bryant wrote: > These new options can be used for passing drive file descriptors > on the command line, instead of using the file option to specify > a file name. > > These new command line options mirror the existing add-fd QMP > command which allows an fd to