Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Alex Bligh
On 4 Aug 2014, at 14:31, Michael S. Tsirkin wrote: > On Fri, Aug 01, 2014 at 08:12:11PM +0100, Alex Bligh wrote: >> This patch series adds inbound migrate capability from qemu-kvm version >> 1.0. The main ideas are those set out in Cole Robinson's patch here: >> http://pkgs.fedoraproject.org/cgi

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 02:51:01PM +0100, Alex Bligh wrote: > > On 4 Aug 2014, at 14:31, Michael S. Tsirkin wrote: > > > On Fri, Aug 01, 2014 at 08:12:11PM +0100, Alex Bligh wrote: > >> This patch series adds inbound migrate capability from qemu-kvm version > >> 1.0. The main ideas are those set

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Alex Bligh
Michael, On 4 Aug 2014, at 15:26, Michael S. Tsirkin wrote: >> >> Unless I'm missing what you are saying? > > I think you are: check how vmstate_test_use_acpi_pci_hotplug > and vmstate_test_no_use_acpi_pci_hotplug are used > in vmstate_acpi. I /think/ you are talking about using the VMSTATE_F

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 05:11:11PM +0100, Alex Bligh wrote: > Michael, > > On 4 Aug 2014, at 15:26, Michael S. Tsirkin wrote: > > >> > >> Unless I'm missing what you are saying? > > > > I think you are: check how vmstate_test_use_acpi_pci_hotplug > > and vmstate_test_no_use_acpi_pci_hotplug ar

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Alex Bligh
Michael, On 4 Aug 2014, at 17:22, Michael S. Tsirkin wrote: >> >> These are capable of modifying fields within the >> VMStateDescription of the relevant object. >> >> However, the PIIX4 change modifies the minimum_version_id >> (outside fields); I don't quite see how that would work. >> Can yo

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 05:46:58PM +0100, Alex Bligh wrote: > Michael, > > On 4 Aug 2014, at 17:22, Michael S. Tsirkin wrote: > > >> > >> These are capable of modifying fields within the > >> VMStateDescription of the relevant object. > >> > >> However, the PIIX4 change modifies the minimum_ve

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Alex Bligh
On 4 Aug 2014, at 17:59, Michael S. Tsirkin wrote: > I was merely suggesting changing acpi_load_old to > detect the new flag and parse the qemu-kvm format. Oh OK - far simpler. If the machine is subsequently migrated to another qemu-2.x device, I take it that will still write out a proper vers

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-04 Thread Michael S. Tsirkin
On Mon, Aug 04, 2014 at 06:08:05PM +0100, Alex Bligh wrote: > > On 4 Aug 2014, at 17:59, Michael S. Tsirkin wrote: > > > I was merely suggesting changing acpi_load_old to > > detect the new flag and parse the qemu-kvm format. > > Oh OK - far simpler. > > If the machine is subsequently migrated

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-06 Thread Alex Bligh
Serge, On 7 Aug 2014, at 03:50, Serge Hallyn wrote: > This worked for me when migrating by hand. I'm trying to make it work > through libvirt, using the following patch. (So whether to have > pc-1.0 be treated as qemu's or qemu-kvm's pc-1.0 is specifed using a > boolean in /etc/libvirt/qemu.co

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-07 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > Serge, > > On 7 Aug 2014, at 03:50, Serge Hallyn wrote: > > > This worked for me when migrating by hand. I'm trying to make it work > > through libvirt, using the following patch. (So whether to have > > pc-1.0 be treated as qemu's or qemu-kvm's pc-1.0

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-07 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > Serge, > > On 7 Aug 2014, at 03:50, Serge Hallyn wrote: > > > This worked for me when migrating by hand. I'm trying to make it work > > through libvirt, using the following patch. (So whether to have > > pc-1.0 be treated as qemu's or qemu-kvm's pc-1.0

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-08 Thread Alex Bligh
On 7 Aug 2014, at 20:26, Serge E. Hallyn wrote: > A-ha, acpi wasn't a problem. I actually had a general migration > problem even when coming from other utopic hosts. With that fixed, > I've got successful migration from qemu-kvm 1.0 in precise to > a utopic host. That's good news. You might t

Re: [libvirt] [Qemu-devel] [PATCH v2 0/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm

2014-08-08 Thread Serge E. Hallyn
Quoting Alex Bligh (a...@alex.org.uk): > > On 7 Aug 2014, at 20:26, Serge E. Hallyn wrote: > > > A-ha, acpi wasn't a problem. I actually had a general migration > > problem even when coming from other utopic hosts. With that fixed, > > I've got successful migration from qemu-kvm 1.0 in precise