Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 16:02, Laine Stump wrote: >>> >> It seems like this is just pointing out another flaw in the semantics >> of DEVICE_DELETED, a device can linger without a device id, so there's >> no way to reference it via QMP. > > Ah, right. I hadn't caught that. Yeah, since it's the device id th

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-06 Thread Paolo Bonzini
On 06/09/2016 04:18, Alex Williamson wrote: > On Mon, 5 Sep 2016 11:36:55 +0200 > Paolo Bonzini wrote: >> DEVICE_DELETED does have a meaning: management cannot talk to the device >> anymore in QMP once it is raised. > > It seems like this is just pointing out another flaw in the semantics > of

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-06 Thread Laine Stump
On 09/05/2016 10:18 PM, Alex Williamson wrote: On Mon, 5 Sep 2016 11:36:55 +0200 Paolo Bonzini wrote: On 05/09/2016 11:23, Markus Armbruster wrote: On the other hand, it is clearly documented that the DEVICE_DELETED event is sent as soon as guest acknowledges completion of device removal. So

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Alex Williamson
On Mon, 5 Sep 2016 11:36:55 +0200 Paolo Bonzini wrote: > On 05/09/2016 11:23, Markus Armbruster wrote: > >> > > >> > On the other hand, it is clearly documented that the DEVICE_DELETED > >> > event is sent as soon as guest acknowledges completion of device > >> > removal. So libvirt's buggy if we

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Laine Stump
On 09/05/2016 05:36 AM, Paolo Bonzini wrote: On 05/09/2016 11:23, Markus Armbruster wrote: On the other hand, it is clearly documented that the DEVICE_DELETED event is sent as soon as guest acknowledges completion of device removal. So libvirt's buggy if we'd follow documentation strictly. But

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Paolo Bonzini
On 05/09/2016 11:23, Markus Armbruster wrote: >> > >> > On the other hand, it is clearly documented that the DEVICE_DELETED >> > event is sent as soon as guest acknowledges completion of device >> > removal. So libvirt's buggy if we'd follow documentation strictly. But >> > then again, I don't se

Re: [libvirt] [Qemu-devel] qapi DEVICE_DELETED event issued *before* instance_finalize?!

2016-09-05 Thread Markus Armbruster
Adding Paolo. Michal Privoznik writes: > On 02.09.2016 01:11, Alex Williamson wrote: >> Hey, >> >> I'm out of my QOM depth, so I'll just beg for help in advance. I >> noticed in testing vfio-pci hotunplug that the host seems to be trying >> to reclaim the device before QEMU is actually done wi