Re: [libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-19 Thread Chen HanXiao
>On Thu, Apr 19, 2012 at 03:04:09PM +0200, Michal Privoznik wrote: >> On 19.04.2012 14:45, Richard W.M. Jones wrote: >> > On Thu, Apr 19, 2012 at 02:25:16PM +0800, Chen Hanxiao wrote: >> >> * This is an arbitrary limit designed to stop the decoder from trying >> >> * to allocate unbounded amoun

Re: [libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-19 Thread Richard W.M. Jones
On Thu, Apr 19, 2012 at 03:04:09PM +0200, Michal Privoznik wrote: > On 19.04.2012 14:45, Richard W.M. Jones wrote: > > On Thu, Apr 19, 2012 at 02:25:16PM +0800, Chen Hanxiao wrote: > >> * This is an arbitrary limit designed to stop the decoder from trying > >> * to allocate unbounded amounts of

Re: [libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-19 Thread Michal Privoznik
On 19.04.2012 14:45, Richard W.M. Jones wrote: > On Thu, Apr 19, 2012 at 02:25:16PM +0800, Chen Hanxiao wrote: >> * This is an arbitrary limit designed to stop the decoder from trying >> * to allocate unbounded amounts of memory when fed with a bad message. >> */ >> -const REMOTE_STRING_MAX =

Re: [libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-19 Thread Richard W.M. Jones
On Thu, Apr 19, 2012 at 02:25:16PM +0800, Chen Hanxiao wrote: > * This is an arbitrary limit designed to stop the decoder from trying > * to allocate unbounded amounts of memory when fed with a bad message. > */ > -const REMOTE_STRING_MAX = 65536; > +const REMOTE_STRING_MAX = 8; Can this

Re: [libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-19 Thread Michal Privoznik
On 19.04.2012 08:25, Chen Hanxiao wrote: > From: Chen Hanxiao > > When adding a large number of virtio storage devices to > virtual machine by using 'virsh edit' command, there is > a problem: > When we added more than 190 virtio disks by 'virsh edit' > command, we got a feedback as 'error: Unabl

[libvirt] [RFC][PATCH] Revision for message payload encoding error when adding a large mount of virtio disks

2012-04-18 Thread Chen Hanxiao
From: Chen Hanxiao When adding a large number of virtio storage devices to virtual machine by using 'virsh edit' command, there is a problem: When we added more than 190 virtio disks by 'virsh edit' command, we got a feedback as 'error: Unable to encode message payload'. In virt-mananger, the sam