Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-13 Thread Daniel P. Berrange
On Fri, May 08, 2009 at 07:10:02PM -0300, Eduardo Otubo wrote: Here is the phyp_driver.c with the memory leaks fixed with your suggestions. With those things done, do you think this code is enough and compliant to libvirt patterns to be included in the next libvirt release? Yep, the

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-08 Thread Eduardo Otubo
Em Qua, 2009-05-06 às 09:44 +0100, Daniel P. Berrange escreveu: On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: + +/* return the lpar_id given a name and a managed system name */ +static int +phypGetLparID(SSH_SESSION * ssh_session, const char *managed_system,

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-06 Thread Daniel Veillard
On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: Hello DV, Hi Eduardo, sorry for the delay I took a few days of vacations :-) I agree with your suggestions and everything is fixed now. But I would like to discuss some points. good ! +while (channel

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-06 Thread Daniel P. Berrange
On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: + +/* return the lpar_id given a name and a managed system name */ +static int +phypGetLparID(SSH_SESSION * ssh_session, const char *managed_system, + const char *name) +{ +int exit_status = 0;

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-06 Thread Eduardo Otubo
Em Qua, 2009-05-06 às 09:26 +0200, Daniel Veillard escreveu: On Mon, May 04, 2009 at 05:50:03PM -0300, Eduardo Otubo wrote: Hello DV, Hi Eduardo, sorry for the delay I took a few days of vacations :-) Hello DV, Nice! Hope you enjoyed your vacations :) +while (channel

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-05-04 Thread Eduardo Otubo
Hello DV, I agree with your suggestions and everything is fixed now. But I would like to discuss some points. +while (channel channel_is_open(channel)) { +ret = channel_read(channel, readbuf, 0, 0); +if (ret 0) { +(*exit_status) =

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-04-29 Thread Daniel Veillard
On Thu, Apr 23, 2009 at 06:44:13PM -0300, Eduardo Otubo wrote: I very am glad with all the feedback I got. The following attachtment is the result of the work using all the suggestions the list made. I also have a few comments over this new RFC. Here is a little Changelog: [...] ---

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-04-23 Thread Eduardo Otubo
Hello again, I very am glad with all the feedback I got. The following attachtment is the result of the work using all the suggestions the list made. I also have a few comments over this new RFC. Here is a little Changelog: * Now the URI is recognized as phyp://u...@hmc/managed_system. To use

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-31 Thread Eduardo Otubo
Hello Daniel, Look, I don't want to make big deal about this, I'll just answer these points below with some arguments they gave me. If we find out libssh2 is better, I' can change it, no problem at all. In fact I use libssh http://0xbadc0de.be/wiki/libssh:libssh and not libssh2. I choosed

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-30 Thread Daniel P. Berrange
On Fri, Mar 27, 2009 at 05:33:43PM -0300, Eduardo Otubo wrote: @@ -714,6 +716,21 @@ AM_CONDITIONAL([HAVE_NUMACTL], [test $with_numactl != no]) AC_SUBST([NUMACTL_CFLAGS]) AC_SUBST([NUMACTL_LIBS]) +if test $with_phyp = yes; then + AC_CHECK_LIB([ssh],[ssh_new],[ +

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-27 Thread Eduardo Otubo
Hello Kaitlin, +#include domain_conf.h +/* Main driver state */ +typedef struct __phyp_driver phyp_driver_t; +struct __phyp_driver { +virMutex lock; + +virCapsPtr *caps; + +virDomainObjList *domains; + +char *configDir; +char *autostartDir;

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-27 Thread Eduardo Otubo
Hello Daniel, The protocol between the console and the partition (LPAR) is not disclosed, therefore I propose the driver to execute commands remoetly over an SSH connection to the consoles to manage IBM LPARs. That seems like a reasonably choice, unless the web server in the HMC/IVM

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-26 Thread Daniel P. Berrange
On Fri, Mar 20, 2009 at 01:58:50PM -0300, Eduardo Otubo wrote: I've been working on a libvirt extension to manage IBM's Power VMs (LPARs). The Power systems are managed through management console referred to as the HMC or using a management partition (IVM). Both HMC and IVM runs an SSH, then

Re: [libvirt] [RFC] Power Hypervisor Libvirt support

2009-03-20 Thread Eduardo Otubo
Sorry all about my last email, the subject should be [RFC] Power Hypervisor Libvirt support. There should be an error here. Thanks again, Em Sex, 2009-03-20 às 13:58 -0300, Eduardo Otubo escreveu: Hello all, I've been working on a libvirt extension to manage IBM's Power VMs (LPARs). The