Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Martin Kletzander
On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew == virConnectClass virConnectCloseCallbackDataClass virDomainClass These three are not related to libvirt-admin, they are

Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Guido Günther
On Wed, Aug 12, 2015 at 10:37:30AM +0200, Martin Kletzander wrote: On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew == virConnectClass virConnectCloseCallbackDataClass

Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Daniel P. Berrange
On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew virConnectClass virConnectCloseCallbackDataClass virDomainClass ... I marked the one symbol needed by the deamon as

Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Guido Günther
On Wed, Aug 12, 2015 at 01:07:46PM +0100, Daniel P. Berrange wrote: On Wed, Aug 12, 2015 at 01:49:46PM +0200, Guido Günther wrote: On Wed, Aug 12, 2015 at 11:15:58AM +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking

Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Daniel P. Berrange
On Wed, Aug 12, 2015 at 01:49:46PM +0200, Guido Günther wrote: On Wed, Aug 12, 2015 at 11:15:58AM +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew

Re: [libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-12 Thread Guido Günther
On Wed, Aug 12, 2015 at 11:15:58AM +0100, Daniel P. Berrange wrote: On Tue, Aug 11, 2015 at 09:24:59PM +0200, Guido Günther wrote: Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew virConnectClass virConnectCloseCallbackDataClass

[libvirt] [RFC] libvirt-admin: Mark symbols as local

2015-08-11 Thread Guido Günther
Otherwise we're leaking some 30+ symbols like virAdmConnectClass virAdmConnectNew virConnectClass virConnectCloseCallbackDataClass virDomainClass ... I marked the one symbol needed by the deamon as LIBVIRT_ADMIN_PRIVATE_VERSION for now. --- There's likely a better solution for