Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-14 Thread Daniel P. Berrange
On Wed, Nov 05, 2008 at 05:32:36PM -0500, David Lively wrote: Ugh. I see what you mean. It seems more complicated than that, though. For one thing, the AvahiWatch/AvahiPoll stuff is sufficiently abstract that it doesn't mention DBusConnection (or any other DBus type, AFAIK), so there's no

RE: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-14 Thread Ben Guthro
-list Subject: Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent On Wed, Nov 05, 2008 at 05:32:36PM -0500, David Lively wrote: Ugh. I see what you mean. It seems more complicated than that, though. For one thing, the AvahiWatch/AvahiPoll stuff is sufficiently abstract

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-14 Thread Daniel P. Berrange
On Fri, Nov 14, 2008 at 07:36:27AM -0500, Ben Guthro wrote: I'll answer for Dave, while I'm looking at this. As far as I know, Dave is of the opinion that we are just getting lucky using the APIs as we are, and remains convinced that his suggested change is necessary here. He (and I)

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-14 Thread Daniel P. Berrange
On Fri, Nov 14, 2008 at 10:46:22AM -0500, David Lively wrote: On Fri, 2008-11-14 at 14:11 +, Daniel P. Berrange wrote: On Fri, Nov 14, 2008 at 07:36:27AM -0500, Ben Guthro wrote: I'll answer for Dave, while I'm looking at this. As far as I know, Dave is of the opinion that we are

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-05 Thread Daniel P. Berrange
On Tue, Nov 04, 2008 at 07:04:54AM -0500, Ben Guthro wrote: I'll respond now while I'm looking at this, as Dave may not be able to get to this until later today I was talking with Dave about this yesterday, and if I'm not mistaken, this idea comes from some of the implementations for

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-05 Thread David Lively
On Wed, 2008-11-05 at 11:51 +, Daniel P. Berrange wrote: DevKit HAL are just APIs built ontop of DBus, so the key here is integration with DBus watch APIs. AFAIK, those only require that the event loop impl have one callback per unique FD. Here's what I'm seeing when registering for dbus

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-05 Thread Daniel P. Berrange
On Wed, Nov 05, 2008 at 11:26:07AM -0500, David Lively wrote: On Wed, 2008-11-05 at 11:51 +, Daniel P. Berrange wrote: DevKit HAL are just APIs built ontop of DBus, so the key here is integration with DBus watch APIs. AFAIK, those only require that the event loop impl have one callback

Re: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-05 Thread David Lively
Ugh. I see what you mean. It seems more complicated than that, though. For one thing, the AvahiWatch/AvahiPoll stuff is sufficiently abstract that it doesn't mention DBusConnection (or any other DBus type, AFAIK), so there's no indication that *any* DBusConnection is being used (though I trust

RE: [libvirt] [RFC] making (newly public) EventImpl interface moreconsistent

2008-11-04 Thread Ben Guthro
] [RFC] making (newly public) EventImpl interface moreconsistent On Mon, Nov 03, 2008 at 10:51:36AM -0500, David Lively wrote: Hi Folks - Since virEvent???RegisterImpl is now public (in libvirt.h), a nagging concern of mine has become more urgent. Essentially this callback gives clients