Re: [libvirt] [RFC] virfile: fix cast-align error

2018-10-09 Thread Bjoern Walk
Michal Privoznik [2018-10-09, 04:52PM +0200]: > What header file are you looking at? From /usr/include/bits/statfs.h: It's s390x-specific hard-coded as an unsigned int. > > Also, I am against exposing any > > internal data types. > > It's not internal if it is exposed in a public header file.

Re: [libvirt] [RFC] virfile: fix cast-align error

2018-10-09 Thread Michal Privoznik
On 10/09/2018 04:39 PM, Bjoern Walk wrote: > Michal Privoznik [2018-10-09, 03:45PM +0200]: >> On 10/08/2018 08:41 PM, Marc Hartmayer wrote: >>> Use the correct type in order to fix the following error on s390x: >>> >>> In function 'virFileIsSharedFSType': >>> ../../src/util/virfile.c:3578:38:

Re: [libvirt] [RFC] virfile: fix cast-align error

2018-10-09 Thread Bjoern Walk
Michal Privoznik [2018-10-09, 03:45PM +0200]: > On 10/08/2018 08:41 PM, Marc Hartmayer wrote: > > Use the correct type in order to fix the following error on s390x: > > > > In function 'virFileIsSharedFSType': > > ../../src/util/virfile.c:3578:38: error: cast increases required alignment > > of

Re: [libvirt] [RFC] virfile: fix cast-align error

2018-10-09 Thread Michal Privoznik
On 10/08/2018 08:41 PM, Marc Hartmayer wrote: > Use the correct type in order to fix the following error on s390x: > > In function 'virFileIsSharedFSType': > ../../src/util/virfile.c:3578:38: error: cast increases required alignment of > target type [-Werror=cast-align] >

Re: [libvirt] [RFC] virfile: fix cast-align error

2018-10-09 Thread Bjoern Walk
Marc Hartmayer [2018-10-08, 08:41PM +0200]: > Use the correct type in order to fix the following error on s390x: > > In function 'virFileIsSharedFSType': > ../../src/util/virfile.c:3578:38: error: cast increases required alignment of > target type [-Werror=cast-align] >

[libvirt] [RFC] virfile: fix cast-align error

2018-10-08 Thread Marc Hartmayer
Use the correct type in order to fix the following error on s390x: In function 'virFileIsSharedFSType': ../../src/util/virfile.c:3578:38: error: cast increases required alignment of target type [-Werror=cast-align] virFileIsSharedFixFUSE(path, (long *) _type); Signed-off-by: Marc