Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 06:15:14PM -0200, Eduardo Habkost wrote: > On Thu, Dec 04, 2008 at 07:32:20PM +, Daniel P. Berrange wrote: > > On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: > > > > > > > I was going to suggest having something like this: > > > > > > virNetworkAddT

Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Eduardo Habkost
On Thu, Dec 04, 2008 at 07:32:20PM +, Daniel P. Berrange wrote: > On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: > > > > I was going to suggest having something like this: > > > > virNetworkAddTap(network, &net->ifname, &tapfd); > > This isn't satisfactory. This only work

Re: [libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Daniel P. Berrange
On Thu, Dec 04, 2008 at 03:42:12PM -0200, Eduardo Habkost wrote: > Hi, > > Below is an incomplete patch for letting the MTU of a libvirt virtual > network to be configured on XML. > > This implementation has an issue: it works when trying to set the MTU > below 1500, but the kernel bridge code do

[libvirt] [RFC PATCH] Let network bridge MTU to be configured on XML

2008-12-04 Thread Eduardo Habkost
Hi, Below is an incomplete patch for letting the MTU of a libvirt virtual network to be configured on XML. This implementation has an issue: it works when trying to set the MTU below 1500, but the kernel bridge code doesn't let us to set the bridge MTU above 1500 if there is no interface attached