Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-28 Thread Alexey Kardashevskiy
On 09/26/2014 12:05 AM, Alexey Kardashevskiy wrote: On 09/25/2014 10:39 PM, Kevin Wolf wrote: Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: On 09/25/2014 08:20 PM, Kevin Wolf wrote: Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/24/2014 07:48 PM, Kevin Wolf wrote: Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 10:41 hat Alexey Kardashevskiy geschrieben: On 09/24/2014 07:48 PM, Kevin Wolf wrote: Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 06:57 PM, Kevin Wolf wrote: Am 25.09.2014 um 10:41 hat Alexey Kardashevskiy geschrieben: On 09/24/2014 07:48 PM, Kevin Wolf wrote: Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was suggested? I am doublechecking as it does not solve the original issue - the bottomhalf is called first and then nbd_trip() crashes in qcow2_co_flush_to_os(). diff --git a/block.c b/block.c index

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 08:20 PM, Kevin Wolf wrote: Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was suggested? I am doublechecking as it does not solve the original issue - the bottomhalf is called first and then nbd_trip() crashes in

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Kevin Wolf
Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: On 09/25/2014 08:20 PM, Kevin Wolf wrote: Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was suggested? I am doublechecking as it does not solve the original issue - the bottomhalf is

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-25 Thread Alexey Kardashevskiy
On 09/25/2014 10:39 PM, Kevin Wolf wrote: Am 25.09.2014 um 14:29 hat Alexey Kardashevskiy geschrieben: On 09/25/2014 08:20 PM, Kevin Wolf wrote: Am 25.09.2014 um 11:55 hat Alexey Kardashevskiy geschrieben: Right. Cool. So is below what was suggested? I am doublechecking as it does not solve

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-24 Thread Alexey Kardashevskiy
On 09/23/2014 06:47 PM, Alexey Kardashevskiy wrote: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more general one. I

Re: [libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-24 Thread Kevin Wolf
Am 23.09.2014 um 10:47 hat Alexey Kardashevskiy geschrieben: On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more

[libvirt] [RFC PATCH] qcow2: Fix race in cache invalidation

2014-09-23 Thread Alexey Kardashevskiy
On 09/19/2014 06:47 PM, Kevin Wolf wrote: Am 16.09.2014 um 14:59 hat Paolo Bonzini geschrieben: Il 16/09/2014 14:52, Kevin Wolf ha scritto: Yes, that's true. We can't fix this problem in qcow2, though, because it's a more general one. I think we must make sure that bdrv_invalidate_cache()