Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 20.04.2018 um 10:50 hat Peter Krempa geschrieben: > On Fri, Apr 20, 2018 at 10:41:50 +0200, Kevin Wolf wrote: > > Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > > > Is there a special need to use 'host_cdrom' explicitly if the CDROM > > > drive is used? That would complicate things

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

On Fri, Apr 20, 2018 at 10:41:50 +0200, Kevin Wolf wrote: > Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > > Is there a special need to use 'host_cdrom' explicitly if the CDROM > > drive is used? That would complicate things since we don't know when > > that will happen. > > You don't get

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 20.04.2018 um 09:56 hat Peter Krempa geschrieben: > Is there a special need to use 'host_cdrom' explicitly if the CDROM > drive is used? That would complicate things since we don't know when > that will happen. You don't get the full CD-ROM passthrough functionality with host_device.

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

On Fri, Apr 20, 2018 at 09:45:40 +0200, Kevin Wolf wrote: > Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > > 'file' backend in qemu supports few more options than the current > > implementation. Extract it so that changes don't pollute the code. > > > > Signed-off-by: Peter Krempa

Re: [libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

Am 19.04.2018 um 17:25 hat Peter Krempa geschrieben: > 'file' backend in qemu supports few more options than the current > implementation. Extract it so that changes don't pollute the code. > > Signed-off-by: Peter Krempa > --- > src/qemu/qemu_block.c | 16 +--- >

[libvirt] [RFC PATCH 05/30] qemu: block: Extract formatting of props for 'file' backend

'file' backend in qemu supports few more options than the current implementation. Extract it so that changes don't pollute the code. Signed-off-by: Peter Krempa --- src/qemu/qemu_block.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git