Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Daniel P. Berrange
On Fri, May 22, 2015 at 11:56:24AM +0200, Michal Privoznik wrote: On 20.05.2015 19:35, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote:

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Michal Privoznik
On 20.05.2015 19:35, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread John Ferlan
On 05/22/2015 08:26 AM, Daniel P. Berrange wrote: RPM preserves mtimes, not ctimes. We use ctimes since commit f5059a929e0db6689e908e354b13a60661c143e1 Change QEMU capabilities cache to check ctime instead of mtime CommitDate: 2014-03-11 10:52:29 +

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Daniel P. Berrange
On Fri, May 22, 2015 at 09:00:27AM -0400, John Ferlan wrote: On 05/22/2015 08:26 AM, Daniel P. Berrange wrote: RPM preserves mtimes, not ctimes. We use ctimes since commit f5059a929e0db6689e908e354b13a60661c143e1 Change QEMU capabilities cache to check ctime instead of mtime

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Ján Tomko
On Fri, May 22, 2015 at 11:02:57AM +0100, Daniel P. Berrange wrote: On Fri, May 22, 2015 at 11:56:24AM +0200, Michal Privoznik wrote: On 20.05.2015 19:35, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Daniel P. Berrange
On Fri, May 22, 2015 at 02:23:12PM +0200, Ján Tomko wrote: On Fri, May 22, 2015 at 11:02:57AM +0100, Daniel P. Berrange wrote: On Fri, May 22, 2015 at 11:56:24AM +0200, Michal Privoznik wrote: On 20.05.2015 19:35, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote:

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-22 Thread Ján Tomko
On Fri, May 22, 2015 at 11:56:24AM +0200, Michal Privoznik wrote: On 20.05.2015 19:35, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote:

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-21 Thread Ján Tomko
On Wed, May 20, 2015 at 01:35:43PM -0400, John Ferlan wrote: On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id

[libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU binary time didn't match or if the new libvirtd ctime was later

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread Daniel P. Berrange
On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes; however, the code only discarded if the QEMU

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
On 05/20/2015 09:28 AM, Daniel P. Berrange wrote: On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime'

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread Ján Tomko
s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the QEMU binary or libvirtd 'ctime' changes;

Re: [libvirt] [RFC PATCH 2/2] qemu: Force capabilities cache read if libvirtd date is different

2015-05-20 Thread John Ferlan
On 05/20/2015 10:22 AM, Ján Tomko wrote: s/read/refresh/ in the commit message? On Wed, May 20, 2015 at 08:52:57AM -0400, John Ferlan wrote: https://bugzilla.redhat.com/show_bug.cgi?id=1195882 Original commit id 'cbde3589' indicates that the cache file would be discarded if either the