Re: [libvirt] [RFC PATCH 3/6] qemu: Use helper functions for handling cmd line capabilities

2011-02-11 Thread Eric Blake
On 02/10/2011 06:02 AM, Jiri Denemark wrote: Certainly a tougher prospect. On the surface, it looks correct; however, I'm worried that there might be some potential for a data race bug - that is, if we ever have any command that can build a command line string while holding a read-only

Re: [libvirt] [RFC PATCH 3/6] qemu: Use helper functions for handling cmd line capabilities

2011-02-10 Thread Jiri Denemark
@@ -3181,12 +3181,18 @@ qemuBuildCommandLine(virConnectPtr conn, devices. Fortunately, those don't need static PCI addresses, so we don't really care that we can't use -device */ -if ((qemuCmdFlags QEMU_CAPS_DEVICE) -

Re: [libvirt] [RFC PATCH 3/6] qemu: Use helper functions for handling cmd line capabilities

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: --- No comment in the commit message about the name of the new helper methods? src/qemu/qemu_capabilities.c | 152 ++-- src/qemu/qemu_capabilities.h |9 ++ src/qemu/qemu_command.c | 260