Re: [libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-11 Thread Eric Blake
On 02/10/2011 07:03 AM, Jiri Denemark wrote: +va_start(list, caps); +while ((flag = va_arg(list, int)) QEMU_CAPS_LAST) This is the bug I was talking about in the previous email. I should rather use enum qemuCapsFlags instead of int in case someone passes -fshort-enum option to gcc

Re: [libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-10 Thread Jiri Denemark
On Wed, Feb 09, 2011 at 10:33:01 -0700, Eric Blake wrote: On 02/09/2011 09:02 AM, Jiri Denemark wrote: This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 +

[libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-09 Thread Jiri Denemark
This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 + tests/qemuhelptest.c | 727 +- tests/qemuxml2argvtest.c | 468

Re: [libvirt] [RFC PATCH 6/6] tests: Use virBitmap for qemu command line caps

2011-02-09 Thread Eric Blake
On 02/09/2011 09:02 AM, Jiri Denemark wrote: This needs to be squashed into the previous patch but is provided separately for easier review. --- src/qemu/qemu_capabilities.c | 14 + src/qemu/qemu_capabilities.h |2 + tests/qemuhelptest.c | 727