Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-10-13 Thread Michal Privoznik
On 22.09.2015 14:15, Martin Kletzander wrote: > In order for the user to be able to fix broken domains function > qemuDomainGetXMLDesc() needs to be able to lookup invalid domain > definitions and handle them properly. When redefined, function > qemuDomainDefineXMLFlags() must clear the 'invalid

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-10-13 Thread Martin Kletzander
On Tue, Oct 13, 2015 at 12:10:05PM +0200, Michal Privoznik wrote: On 22.09.2015 14:15, Martin Kletzander wrote: In order for the user to be able to fix broken domains function qemuDomainGetXMLDesc() needs to be able to lookup invalid domain definitions and handle them properly. When redefined,

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-10-13 Thread Michal Privoznik
On 13.10.2015 15:08, Martin Kletzander wrote: > On Tue, Oct 13, 2015 at 12:10:05PM +0200, Michal Privoznik wrote: >> On 22.09.2015 14:15, Martin Kletzander wrote: >>> In order for the user to be able to fix broken domains function >>> qemuDomainGetXMLDesc() needs to be able to lookup invalid

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-10-06 Thread Daniel P. Berrange
On Tue, Oct 06, 2015 at 03:35:36PM +0200, Michal Privoznik wrote: > On 22.09.2015 15:17, Daniel P. Berrange wrote: > > On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: > >> On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: > >>> On Tue, Sep 22, 2015 at

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-10-06 Thread Michal Privoznik
On 22.09.2015 15:17, Daniel P. Berrange wrote: > On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: >> On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: >>> On Tue, Sep 22, 2015 at 02:15:53PM +0200, Martin Kletzander wrote: In order for the user to be able to

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Martin Kletzander
On Tue, Sep 22, 2015 at 02:36:54PM +0100, Daniel P. Berrange wrote: On Tue, Sep 22, 2015 at 03:26:26PM +0200, Martin Kletzander wrote: On Tue, Sep 22, 2015 at 02:17:14PM +0100, Daniel P. Berrange wrote: >On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: >>On Tue, Sep 22, 2015

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 03:26:26PM +0200, Martin Kletzander wrote: > On Tue, Sep 22, 2015 at 02:17:14PM +0100, Daniel P. Berrange wrote: > >On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: > >>On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: > >>>On Tue, Sep

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Martin Kletzander
On Tue, Sep 22, 2015 at 02:17:14PM +0100, Daniel P. Berrange wrote: On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: >On Tue, Sep 22, 2015 at 02:15:53PM +0200, Martin Kletzander wrote: >>In order for the user

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 02:15:53PM +0200, Martin Kletzander wrote: > In order for the user to be able to fix broken domains function > qemuDomainGetXMLDesc() needs to be able to lookup invalid domain > definitions and handle them properly. When redefined, function > qemuDomainDefineXMLFlags()

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Martin Kletzander
On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: On Tue, Sep 22, 2015 at 02:15:53PM +0200, Martin Kletzander wrote: In order for the user to be able to fix broken domains function qemuDomainGetXMLDesc() needs to be able to lookup invalid domain definitions and handle them

[libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Martin Kletzander
In order for the user to be able to fix broken domains function qemuDomainGetXMLDesc() needs to be able to lookup invalid domain definitions and handle them properly. When redefined, function qemuDomainDefineXMLFlags() must clear the 'invalid XML' reason. As a nice addition, qemuDomainGetState()

Re: [libvirt] [RFC PATCH 7/8] qemu: Prepare basic APIs to handle invalid defs

2015-09-22 Thread Daniel P. Berrange
On Tue, Sep 22, 2015 at 03:12:14PM +0200, Martin Kletzander wrote: > On Tue, Sep 22, 2015 at 01:48:01PM +0100, Daniel P. Berrange wrote: > >On Tue, Sep 22, 2015 at 02:15:53PM +0200, Martin Kletzander wrote: > >>In order for the user to be able to fix broken domains function >