Re: [libvirt] [RFC PATCHv2 4/n] snapshot: actually compute branch definition from XML

2012-11-20 Thread Eric Blake
On 11/19/2012 05:09 PM, Eric Blake wrote: > When asked to parse a branch snapshot XML definition, we have to > piece together the definition of the new snapshot from parts of > the branch point, as well as run some sanity checks that the > branches are compatible. This patch is rather restrictive

Re: [libvirt] [RFC PATCHv2 4/n] snapshot: actually compute branch definition from XML

2012-11-20 Thread Eric Blake
On 11/20/2012 09:41 AM, Peter Krempa wrote: >> @@ -188,6 +188,7 @@ virDomainSnapshotDefParseString(const char *xmlStr, >> char *memorySnapshot = NULL; >> char *memoryFile = NULL; >> bool offline = !!(flags & VIR_DOMAIN_SNAPSHOT_PARSE_OFFLINE); >> +virDomainSnapshotObjPtr other

Re: [libvirt] [RFC PATCHv2 4/n] snapshot: actually compute branch definition from XML

2012-11-20 Thread Peter Krempa
On 11/20/12 01:09, Eric Blake wrote: When asked to parse a branch snapshot XML definition, we have to piece together the definition of the new snapshot from parts of the branch point, as well as run some sanity checks that the branches are compatible. This patch is rather restrictive in what it

[libvirt] [RFC PATCHv2 4/n] snapshot: actually compute branch definition from XML

2012-11-19 Thread Eric Blake
When asked to parse a branch snapshot XML definition, we have to piece together the definition of the new snapshot from parts of the branch point, as well as run some sanity checks that the branches are compatible. This patch is rather restrictive in what it allows; depending on effort and future