Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-29 Thread Jim Fehlig
On 07/29/2015 04:07 PM, Jim Fehlig wrote: On 07/20/2015 09:28 AM, Olaf Hering wrote: On Thu, Jul 16, Jim Fehlig wrote: @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); +virObjectUnref(args); This is now

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-29 Thread Jim Fehlig
On 07/20/2015 09:28 AM, Olaf Hering wrote: On Thu, Jul 16, Jim Fehlig wrote: @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, virObjectUnref(socks[i]); } VIR_FREE(socks); +virObjectUnref(args); This is now below the 'error' label, so args has to be

Re: [libvirt] [Xen-devel] [PATCH 1/3] libxl: fix ref counting of libxlMigrationDstArgs

2015-07-20 Thread Olaf Hering
On Thu, Jul 16, Jim Fehlig wrote: > @@ -448,6 +438,8 @@ libxlDomainMigrationPrepare(virConnectPtr dconn, > virObjectUnref(socks[i]); > } > VIR_FREE(socks); > +virObjectUnref(args); This is now below the 'error' label, so args has to be initialized. [ 149s] libxl/libxl_mig