Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Jim Fehlig
Ian Campbell wrote: > Currently the driver only exposes the ability to connect to the serial console > of a Xen guest, which doesn't work for a PV guest. Since for an HVM guest the > serial devices are duplicated as consoles it is sufficient to just use the > console devices unconditionally. > > Te

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Jim Fehlig
Jim Fehlig wrote: > Ian Campbell wrote: > >> Currently the driver only exposes the ability to connect to the serial >> console >> of a Xen guest, which doesn't work for a PV guest. Since for an HVM guest the >> serial devices are duplicated as consoles it is sufficient to just use the >> consol

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Konrad Rzeszutek Wilk
On Fri, Apr 25, 2014 at 11:24:07AM -0600, Jim Fehlig wrote: > Jim Fehlig wrote: > > Ian Campbell wrote: > > > >> Currently the driver only exposes the ability to connect to the serial > >> console > >> of a Xen guest, which doesn't work for a PV guest. Since for an HVM guest > >> the > >> seri

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Ian Campbell
On Fri, 2014-04-25 at 11:24 -0600, Jim Fehlig wrote: > Jim Fehlig wrote: > > Ian Campbell wrote: > > > >> Currently the driver only exposes the ability to connect to the serial > >> console > >> of a Xen guest, which doesn't work for a PV guest. Since for an HVM guest > >> the > >> serial devi

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Ian Campbell
On Fri, 2014-04-25 at 13:32 -0400, Konrad Rzeszutek Wilk wrote: > The development version of Xen is 4.5. The latest stable > is Xen 4.4. > > If you want to backport it - then your suggestion is correct. > Or just backport the relevant patches ? This patch is against libvirt, which wishes to suppor

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Konrad Rzeszutek Wilk
On Fri, Apr 25, 2014 at 07:52:55PM +0100, Ian Campbell wrote: > On Fri, 2014-04-25 at 13:32 -0400, Konrad Rzeszutek Wilk wrote: > > The development version of Xen is 4.5. The latest stable > > is Xen 4.4. > > > > If you want to backport it - then your suggestion is correct. > > Or just backport the

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-25 Thread Jim Fehlig
Ian Campbell wrote: > On Fri, 2014-04-25 at 11:24 -0600, Jim Fehlig wrote: > >> Jim Fehlig wrote: >> >>> Ian Campbell wrote: >>> >>> Currently the driver only exposes the ability to connect to the serial console of a Xen guest, which doesn't work for a PV guest. Si

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-28 Thread Ian Campbell
On Fri, 2014-04-25 at 14:12 -0600, Jim Fehlig wrote: > I dropped initializing the variable and pushed the patch. > Thanks! Thanks! I rebased to current master (no additional patches on my end) tried to test and suddenly libvirtd is segfaulting in libxl when I run virsh create. The fault is at "ne

Re: [libvirt] [Xen-devel] [PATCH v2] libxl: Support PV consoles

2014-04-28 Thread Ian Campbell
On Mon, 2014-04-28 at 12:17 +0100, Ian Campbell wrote: > On Fri, 2014-04-25 at 14:12 -0600, Jim Fehlig wrote: > > I dropped initializing the variable and pushed the patch. > > Thanks! > > Thanks! I rebased to current master (no additional patches on my end) > tried to test and suddenly libvirtd i