Re: [libvirt] [dbus PATCH v2 1/9] Abandon usage of all *TypeToString functions in domain.c

2018-05-04 Thread Pavel Hrdina
On Fri, May 04, 2018 at 10:38:27AM +0200, Katerina Koukiou wrote: > Converting ENUMS to str can be user friendly though > it can be problematic in matters of backward compatibility. > > In particular when some ENUM in libvirt API will introduce a > new constant, libvirt-dbus will fail with: > >

[libvirt] [dbus PATCH v2 1/9] Abandon usage of all *TypeToString functions in domain.c

2018-05-04 Thread Katerina Koukiou
Converting ENUMS to str can be user friendly though it can be problematic in matters of backward compatibility. In particular when some ENUM in libvirt API will introduce a new constant, libvirt-dbus will fail with: size of array ‘_GStaticAssertCompileTimeAssertion_5’ is negative So using ints