Re: [libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-18 Thread Daniel P. Berrange
On Wed, Jul 18, 2012 at 09:33:58AM +, Cong Wang wrote: > On Fri, 13 Jul 2012 at 07:37 GMT, Jovanka Gulicoska > wrote: > > +gboolean gvir_storage_vol_download(GVirStorageVol *vol, > > + GVirStream *stream, > > + unsigned long

Re: [libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-18 Thread Cong Wang
On Fri, 13 Jul 2012 at 07:37 GMT, Jovanka Gulicoska wrote: > +gboolean gvir_storage_vol_download(GVirStorageVol *vol, > + GVirStream *stream, > + unsigned long long offset, > + unsigned long long

Re: [libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-13 Thread Zeeshan Ali (Khattak)
Hi, Looks pretty stright-forward and correct. Some comments below. I'm already pushing it with these issues fixed. On Fri, Jul 13, 2012 at 10:37 AM, Jovanka Gulicoska wrote: > --- > libvirt-gobject/libvirt-gobject-storage-vol.c | 85 > + > libvirt-gobject/libvirt-go

[libvirt] [glib PATCH V2] Add bindings for virStorageDownload() and virStorageUpload()

2012-07-13 Thread Jovanka Gulicoska
--- libvirt-gobject/libvirt-gobject-storage-vol.c | 85 + libvirt-gobject/libvirt-gobject-storage-vol.h | 14 libvirt-gobject/libvirt-gobject.h |1 + libvirt-gobject/libvirt-gobject.sym |2 + 4 files changed, 102 insertions(+) diff --