Re: [libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

2019-12-23 Thread Cole Robinson
On 12/23/19 5:02 AM, Daniel P. Berrangé wrote: > On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote: >> It was comparing against spapr-vio >> >> Signed-off-by: Cole Robinson >> --- >> All this virtio-s390 stuff is kinda bogus though, because it is >> never actually output in libvirt

Re: [libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

2019-12-23 Thread Daniel P . Berrangé
On Fri, Dec 20, 2019 at 05:22:25PM -0500, Cole Robinson wrote: > It was comparing against spapr-vio > > Signed-off-by: Cole Robinson > --- > All this virtio-s390 stuff is kinda bogus though, because it is > never actually output in libvirt XML. Hmm, I wonder what I was thinking when i added

[libvirt] [go-xml PATCH 1/2] Fix virtio-s390 address lookup

2019-12-20 Thread Cole Robinson
It was comparing against spapr-vio Signed-off-by: Cole Robinson --- All this virtio-s390 stuff is kinda bogus though, because it is never actually output in libvirt XML. domain.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/domain.go b/domain.go index 8c4d7a4..7552c4b