Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

2018-02-07 Thread Andrea Bolognani
On Wed, 2018-02-07 at 13:37 +, Daniel P. Berrangé wrote: > Or can we just use openssl > > $ openssl passwd -crypt hello > RtT4tOPU/wPnU I'd love to avoid embedding a Python script in there[1], but it doesn't look like openssl supports the same strong hashing algorithm we're currently using,

Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

2018-02-07 Thread Daniel P . Berrangé
On Wed, Feb 07, 2018 at 02:32:34PM +0100, Andrea Bolognani wrote: > On Tue, 2018-01-30 at 10:57 +0100, Martin Kletzander wrote: > > On my system the crypt module in python2 doesn't have mksalt() function. > > However python3 does and the code is perfectly fine python3 code as well. > > So > >

Re: [libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

2018-02-07 Thread Andrea Bolognani
On Tue, 2018-01-30 at 10:57 +0100, Martin Kletzander wrote: > On my system the crypt module in python2 doesn't have mksalt() function. > However python3 does and the code is perfectly fine python3 code as well. So > let's make it run in the default python version as that has the highest chance >

[libvirt] [jenkins-ci] lcitool: Use default python for creating salty passwords

2018-01-30 Thread Martin Kletzander
On my system the crypt module in python2 doesn't have mksalt() function. However python3 does and the code is perfectly fine python3 code as well. So let's make it run in the default python version as that has the highest chance to work. Signed-off-by: Martin Kletzander ---