Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:35:12PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > > A friend suggested > > > > > > diff --git a/guests/lcitool b/guests/lcitool > > > index 568e5

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Andrea Bolognani
On Thu, 2018-05-17 at 15:22 +0100, Daniel P. Berrangé wrote: > On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > > A friend suggested > > > > diff --git a/guests/lcitool b/guests/lcitool > > index 568e52c..5855368 100755 > > --- a/guests/lcitool > > +++ b/guests/lcitool > > @@ -2

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 04:10:37PM +0200, Andrea Bolognani wrote: > On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > > Perl to the rescue! The script ends up being only marginally > > > more verbose and obscure as

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Andrea Bolognani
On Thu, 2018-05-17 at 14:18 +0100, Daniel P. Berrangé wrote: > On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > > Perl to the rescue! The script ends up being only marginally > > more verbose and obscure as a result, the indentation is > > significantly better, and it should fina

Re: [libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Daniel P . Berrangé
On Thu, May 17, 2018 at 03:09:11PM +0200, Andrea Bolognani wrote: > We claim to be using Python 2 at the moment: however, we rely > on crypt.mksalt(), which was introduced in Python 3 and has > only been backported to Python 2 in RHEL and Fedora, so the > script will only work on those operating sy

[libvirt] [jenkins-ci PATCH] lcitool: Use Perl to generate password hashes

2018-05-17 Thread Andrea Bolognani
We claim to be using Python 2 at the moment: however, we rely on crypt.mksalt(), which was introduced in Python 3 and has only been backported to Python 2 in RHEL and Fedora, so the script will only work on those operating systems. We could move to Python 3, but the CI nodes are running on a CentO