Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Configure Jenkins agent based on secret availability

2018-03-21 Thread Pavel Hrdina
On Wed, Mar 21, 2018 at 04:08:26PM +0100, Andrea Bolognani wrote: > On Wed, 2018-03-21 at 15:52 +0100, Pavel Hrdina wrote: > > > - name: Enable Jenkins agent > > > @@ -39,4 +45,5 @@ > > > enabled: yes > > > daemon_reload: yes > > >when: > > > +- jenkins_secret is defined > > >

Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Configure Jenkins agent based on secret availability

2018-03-21 Thread Andrea Bolognani
On Wed, 2018-03-21 at 15:52 +0100, Pavel Hrdina wrote: > > - name: Enable Jenkins agent > > @@ -39,4 +45,5 @@ > > enabled: yes > > daemon_reload: yes > >when: > > +- jenkins_secret is defined > > - ansible_service_mgr == 'systemd' > > Would it be possible to create a group

Re: [libvirt] [jenkins-ci PATCH 1/3] guests: Configure Jenkins agent based on secret availability

2018-03-21 Thread Pavel Hrdina
On Tue, Mar 20, 2018 at 05:23:58PM +0100, Andrea Bolognani wrote: > We're going to remove the 'jenkins' pseudo-project from the list > of per-guest projects soon, so we need another way of deciding > whether to install and configure the Jenkins agent. > > The availability of the Jenkins secret in

[libvirt] [jenkins-ci PATCH 1/3] guests: Configure Jenkins agent based on secret availability

2018-03-20 Thread Andrea Bolognani
We're going to remove the 'jenkins' pseudo-project from the list of per-guest projects soon, so we need another way of deciding whether to install and configure the Jenkins agent. The availability of the Jenkins secret in the vault is a perfect candidate, and using it improves things in general