Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Erik Skultety
On Tue, Sep 04, 2018 at 10:33:18AM +0200, Andrea Bolognani wrote: > On Tue, 2018-09-04 at 09:55 +0200, Erik Skultety wrote: > > Initially, I wanted to point out that "revision" is probably not the best > > name > [...] > > I was thinking yesterday that perhaps it would be better to > use '-g

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Andrea Bolognani
On Tue, 2018-09-04 at 09:55 +0200, Erik Skultety wrote: > Initially, I wanted to point out that "revision" is probably not the best name [...] I was thinking yesterday that perhaps it would be better to use '-g GITREVISION' here instead, to leave '-r' available for future extensions, eg. when/if

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-09-04 Thread Erik Skultety
On Fri, Aug 31, 2018 at 12:16:14PM +0200, Andrea Bolognani wrote: > On Wed, 2018-08-29 at 17:08 +0200, Andrea Bolognani wrote: > > This will allow users to build arbitrary branches from > > arbitrary git repositories, but for the moment all it > > does is parse the argument and pass it down to the

Re: [libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-08-31 Thread Andrea Bolognani
On Wed, 2018-08-29 at 17:08 +0200, Andrea Bolognani wrote: > This will allow users to build arbitrary branches from > arbitrary git repositories, but for the moment all it > does is parse the argument and pass it down to the > Ansible playbook. > > Signed-off-by: Andrea Bolognani > --- >

[libvirt] [jenkins-ci PATCH 1/8] lcitool: Add "-r REVISION" argument for build

2018-08-29 Thread Andrea Bolognani
This will allow users to build arbitrary branches from arbitrary git repositories, but for the moment all it does is parse the argument and pass it down to the Ansible playbook. Signed-off-by: Andrea Bolognani --- guests/lcitool | 36 ++-- 1 file changed, 26