Re: [libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-14 Thread Andrea Bolognani
On Thu, 2019-02-14 at 09:59 +, Daniel P. Berrangé wrote: > On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote: > > flake8 complains about this line being too long, so please rewrite > > it as > > What args (if any) are you giving to flake8 when you test this No arguments, just

Re: [libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-14 Thread Daniel P . Berrangé
On Thu, Feb 14, 2019 at 10:46:21AM +0100, Andrea Bolognani wrote: > On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote: > [...] > > @@ -177,8 +177,8 @@ class Inventory: > > parser = configparser.SafeConfigParser() > > parser.read(ansible_cfg_path) > >

Re: [libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-14 Thread Andrea Bolognani
On Wed, 2019-02-13 at 19:03 +, Daniel P. Berrangé wrote: [...] > @@ -177,8 +177,8 @@ class Inventory: > parser = configparser.SafeConfigParser() > parser.read(ansible_cfg_path) > inventory_path = parser.get("defaults", "inventory") > -except

[libvirt] [jenkins-ci PATCH v3 05/10] lcitool: include root cause when reporting errors

2019-02-13 Thread Daniel P . Berrangé
The root cause exception contains the useful information about what really failed during loading of some resource, or running of a command. Signed-off-by: Daniel P. Berrangé --- guests/lcitool | 54 +- 1 file changed, 27 insertions(+), 27