[libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate qemu-kvm tarball. guess_platform_from_connect is starting to be a bit magic, it may be better to add a machine attribute to libosinfo platform

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate qemu-kvm tarball. guess_platform_from_connect is starting to be a bit magic,

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
On Tue, Mar 19, 2013 at 03:24:22PM +, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses qemu-kvm-. Also, starting from qemu 1.2.0, there is no separate

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Daniel P. Berrange
On Tue, Mar 19, 2013 at 04:54:46PM +0100, Christophe Fergeau wrote: On Tue, Mar 19, 2013 at 03:24:22PM +, Daniel P. Berrange wrote: On Tue, Mar 19, 2013 at 10:46:35AM +0100, Christophe Fergeau wrote: The code was building an id starting with kvm- while libosinfo qemu description uses

Re: [libvirt] [libvirt-designer 1/2] Fix libvirt caps - libosinfo platform short id mapping

2013-03-19 Thread Christophe Fergeau
On Tue, Mar 19, 2013 at 03:58:18PM +, Daniel P. Berrange wrote: Perhaps we should be following the approach we use for detecting ISOs, and match against actual product release strings. Libvirt doesn't expose such info, but we could add an API to expose the full product string and/or