Re: [libvirt] [libvirt-glib] [PATCH v4 3/3] GVirDomain: Add async version of _fetch_snapshots

2014-07-09 Thread Timm Bäder
On 07.07, Christophe Fergeau wrote: > Hey, > > On Mon, Jun 30, 2014 at 07:50:16PM +0200, Timm Bäder wrote: > > --- > > libvirt-gobject/libvirt-gobject-domain.c | 60 > > > > libvirt-gobject/libvirt-gobject-domain.h | 10 ++ > > libvirt-gobject/libvirt-gobject

Re: [libvirt] [libvirt-glib] [PATCH v4 3/3] GVirDomain: Add async version of _fetch_snapshots

2014-07-07 Thread Christophe Fergeau
On Mon, Jul 07, 2014 at 02:19:39PM +0200, Christophe Fergeau wrote: > Ideally, this should be changed to be automatically substituted from > whatever is listed in configure.ac. https://www.redhat.com/archives/libvir-list/2014-July/msg00315.html does that. Christophe pgpK7UvPqA4XH.pgp Descripti

Re: [libvirt] [libvirt-glib] [PATCH v4 3/3] GVirDomain: Add async version of _fetch_snapshots

2014-07-07 Thread Christophe Fergeau
On Mon, Jul 07, 2014 at 12:55:33PM +0200, Christophe Fergeau wrote: > GTask was introduced in glib 2.36, so configure.ac needs to be updated > to reflect that. Forgot to add here that the minimum glib requirement is also listed in libvirt-glib.spec.in. Ideally, this should be changed to be automat

Re: [libvirt] [libvirt-glib] [PATCH v4 3/3] GVirDomain: Add async version of _fetch_snapshots

2014-07-07 Thread Christophe Fergeau
Hey, On Mon, Jun 30, 2014 at 07:50:16PM +0200, Timm Bäder wrote: > --- > libvirt-gobject/libvirt-gobject-domain.c | 60 > > libvirt-gobject/libvirt-gobject-domain.h | 10 ++ > libvirt-gobject/libvirt-gobject.sym | 2 ++ > 3 files changed, 72 insertions(

[libvirt] [libvirt-glib] [PATCH v4 3/3] GVirDomain: Add async version of _fetch_snapshots

2014-06-30 Thread Timm Bäder
--- libvirt-gobject/libvirt-gobject-domain.c | 60 libvirt-gobject/libvirt-gobject-domain.h | 10 ++ libvirt-gobject/libvirt-gobject.sym | 2 ++ 3 files changed, 72 insertions(+) diff --git a/libvirt-gobject/libvirt-gobject-domain.c b/libvirt-gobject/li