On Mon, Jan 23, 2012 at 11:31:57PM +0200, Zeeshan Ali (Khattak) wrote:
On Mon, Jan 23, 2012 at 7:19 PM, Christophe Fergeau cferg...@redhat.com
wrote:
Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org
Looks good! I'll test it later
I've only compile-tested it, if it doesn't
On Fri, Jan 20, 2012 at 11:11:57PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 115
+
libvirt-gconfig/libvirt-gconfig-domain.h |8 ++
On Fri, Jan 20, 2012 at 11:11:57PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 115
+
libvirt-gconfig/libvirt-gconfig-domain.h |8 ++
On Mon, Jan 23, 2012 at 1:01 PM, Christophe Fergeau cferg...@redhat.com wrote:
On Fri, Jan 20, 2012 at 11:11:57PM +0200, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 115
+
On Mon, Jan 23, 2012 at 04:53:40PM +0200, Zeeshan Ali (Khattak) wrote:
On Mon, Jan 23, 2012 at 1:01 PM, Christophe Fergeau cferg...@redhat.com
wrote:
I wouldn't make this recursive, I'd just set the namespace on the root
node in case users of the API want to use different namespaces in the
Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 60 +
libvirt-gconfig/libvirt-gconfig-domain.h |7 +++
libvirt-gconfig/libvirt-gconfig-helpers-private.h |1 +
On Mon, Jan 23, 2012 at 7:19 PM, Christophe Fergeau cferg...@redhat.com wrote:
Based on a patch from Zeeshan Ali (Khattak) zeesha...@gnome.org
Looks good! I'll test it later. Some minor issues:
+ gvir_config_object_set_namespace(custom_xml, ns, ns_uri, TRUE);
You meant to pass 'FALSE' in
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c | 115 +
libvirt-gconfig/libvirt-gconfig-domain.h |8 ++
libvirt-gconfig/libvirt-gconfig-helpers.c |4 +-
libvirt-gconfig/libvirt-gconfig.sym |2 +
4