On Tue, May 01, 2012 at 08:30:27PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c |1 +
libvirt-gobject/libvirt-gobject-domain-snapshot.c |1 +
libvirt-gobject/libvirt-gobject-domain.c
What happens when some parameters are not listed/when some blank lines are
missing? Does it output a warning, or abort?
Also, one oddity below,
Christophe
On Tue, May 01, 2012 at 08:30:27PM +0300, Zeeshan Ali (Khattak) wrote:
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau cferg...@redhat.com wrote:
What happens when some parameters are not listed/when some blank lines are
missing?
Does it output a warning, or abort?
You get a warning.
diff --git a/libvirt-gconfig/libvirt-gconfig-domain.c
On Wed, May 02, 2012 at 05:17:19PM +0300, Zeeshan Ali (Khattak) wrote:
On Wed, May 2, 2012 at 1:34 PM, Christophe Fergeau cferg...@redhat.com
wrote:
I'm a bit surprised that here you add a @err annotation, but further down
the patch you rename some @err to @error. Was the renaming an
From: Zeeshan Ali (Khattak) zeesha...@gnome.org
---
libvirt-gconfig/libvirt-gconfig-domain.c |1 +
libvirt-gobject/libvirt-gobject-domain-snapshot.c |1 +
libvirt-gobject/libvirt-gobject-domain.c |3 +++
libvirt-gobject/libvirt-gobject-interface.c |2 ++
