Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-17 Thread Christophe Fergeau
On Tue, Jan 17, 2012 at 05:25:44AM +0200, Zeeshan Ali (Khattak) wrote: On Fri, Jan 13, 2012 at 11:01 AM, Christophe Fergeau cferg...@redhat.com wrote: G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for glib 2.10 at the moment. The patch looks good, but please wait

Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-16 Thread Zeeshan Ali (Khattak)
On Fri, Jan 13, 2012 at 11:01 AM, Christophe Fergeau cferg...@redhat.com wrote: G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for glib 2.10 at the moment. The patch looks good, but please wait until we make a decision on the minimum glib version we require so that we

Re: [libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-13 Thread Christophe Fergeau
G_PARAM_STATIC_STRINGS was added in glib 2.13, configure.ac only check for glib 2.10 at the moment. The patch looks good, but please wait until we make a decision on the minimum glib version we require so that we know if we need to add some fallback for this or not. Imo raising the requirement to

[libvirt] [libvirt-glib] Make use of G_PARAM_STATIC_STRINGS everywhere

2012-01-12 Thread Zeeshan Ali (Khattak)
From: Zeeshan Ali (Khattak) zeesha...@gnome.org --- libvirt-gobject/libvirt-gobject-connection.c | 28 + libvirt-gobject/libvirt-gobject-domain-snapshot.c |4 +-- libvirt-gobject/libvirt-gobject-domain.c |8 +