Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Michal Privoznik
On 12.09.2012 15:55, Christophe Fergeau wrote: --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a network, you'd use a listen child node to the graphics node. This patch sets

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Michal Privoznik
On 25.09.2012 14:47, Christophe Fergeau wrote: On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a network, you'd use a

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 03:04:47PM +0200, Michal Privoznik wrote: On 25.09.2012 14:47, Christophe Fergeau wrote: It seems it's not necessarily an IP address but this can be a hostname if the .rng is to be trusted. I had in the back of my mind the possibility of adding _set_listen_address

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Daniel P. Berrange
On Tue, Sep 25, 2012 at 02:47:30PM +0200, Christophe Fergeau wrote: On Tue, Sep 25, 2012 at 02:07:39PM +0200, Michal Privoznik wrote: Hey, libvirt supports listen on IP address or a network and I think we need to distinguish these. As I understand it, to listen on an IP address or a

Re: [libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-25 Thread Christophe Fergeau
On Tue, Sep 25, 2012 at 03:32:10PM +0100, Daniel P. Berrange wrote: I wonder if we should simply not expose an API for the listen= attribute at all. Only have APIs for reading/writing the listen elements [...] IOW, I don't think applications should need to care about the listen= attribute at

[libvirt] [libvirt-glib 1/4] config: Implement gvir_config_domain_graphics_spice_set_listen

2012-09-12 Thread Christophe Fergeau
--- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ libvirt-gconfig/tests/test-domain-create.c | 1 + 4 files changed, 16