Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-03 Thread Daniel P. Berrange
On Thu, May 02, 2013 at 11:17:49PM +0200, Christophe Fergeau wrote: On Thu, May 02, 2013 at 11:40:56PM +0300, Zeeshan Ali (Khattak) wrote: On Thu, May 2, 2013 at 6:36 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote:

[libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-02 Thread Christophe Fergeau
--- .../libvirt-gconfig-domain-snapshot-disk.c | 81 ++ .../libvirt-gconfig-domain-snapshot-disk.h | 16 + libvirt-gconfig/libvirt-gconfig.sym| 9 +++ 3 files changed, 106 insertions(+) diff --git

Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-02 Thread Zeeshan Ali (Khattak)
On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com wrote: --- .../libvirt-gconfig-domain-snapshot-disk.c | 81 ++ .../libvirt-gconfig-domain-snapshot-disk.h | 16 + libvirt-gconfig/libvirt-gconfig.sym| 9 +++ 3

Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-02 Thread Christophe Fergeau
On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com wrote: + + +const char *gvir_config_domain_snapshot_disk_get_driver_type(GVirConfigDomainSnapshotDisk *disk) Shouldn't 'driver_type' be

Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-02 Thread Zeeshan Ali (Khattak)
On Thu, May 2, 2013 at 6:36 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com wrote: + + +const char

Re: [libvirt] [libvirt-glib 2/3] gconfig: Add GVirConfigDomainSnapshotDisk getters/setters

2013-05-02 Thread Christophe Fergeau
On Thu, May 02, 2013 at 11:40:56PM +0300, Zeeshan Ali (Khattak) wrote: On Thu, May 2, 2013 at 6:36 PM, Christophe Fergeau cferg...@redhat.com wrote: On Thu, May 02, 2013 at 06:22:14PM +0300, Zeeshan Ali (Khattak) wrote: On Wed, May 1, 2013 at 10:59 PM, Christophe Fergeau cferg...@redhat.com