Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-26 Thread Michal Privoznik
On 25.09.2012 14:30, Michal Privoznik wrote: On 25.09.2012 11:21, Christophe Fergeau wrote: Ping? Can this patch go as is, or do we want to go all the way to switching to GInitable as Marc-André suggested in http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? Christophe I

Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-25 Thread Christophe Fergeau
Ping? Can this patch go as is, or do we want to go all the way to switching to GInitable as Marc-André suggested in http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? Christophe On Tue, Jul 24, 2012 at 05:49:21PM +0200, Christophe Fergeau wrote: For objects with a subtype

Re: [libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-09-25 Thread Michal Privoznik
On 25.09.2012 11:21, Christophe Fergeau wrote: Ping? Can this patch go as is, or do we want to go all the way to switching to GInitable as Marc-André suggested in http://www.mail-archive.com/libvir-list@redhat.com/msg59538.html ? Christophe I think your approach is good, however

[libvirt] [libvirt-glib PATCHv3] Fix *_new_from_xml

2012-07-24 Thread Christophe Fergeau
For objects with a subtype 'type' attribute, when the _new_from_xml function was called, the 'type' attribute was forcefully set to the right value rather than checking that the passed-in value matches the type of the subclass we are trying to instantiate. This commit changes this, and returns