Re: [libvirt] [libvirt-glib v3 3/4] Add GVirConfigDomainCpuModel class

2014-08-01 Thread Zeeshan Ali (Khattak)
On Fri, Jul 25, 2014 at 3:20 PM, Christophe Fergeau wrote: > Hey, > > Looks good, ACK. It would have been worth adding support for 'fallback' > and 'vendor_id' while you were digging in that code, easier than having > to come back dive in that code later when that's needed imo. Sure, I'll submit

Re: [libvirt] [libvirt-glib v3 3/4] Add GVirConfigDomainCpuModel class

2014-07-25 Thread Christophe Fergeau
Hey, Looks good, ACK. It would have been worth adding support for 'fallback' and 'vendor_id' while you were digging in that code, easier than having to come back dive in that code later when that's needed imo. Christophe On Tue, Jul 15, 2014 at 11:42:31PM +0100, Zeeshan Ali (Khattak) wrote: > Ad

[libvirt] [libvirt-glib v3 3/4] Add GVirConfigDomainCpuModel class

2014-07-15 Thread Zeeshan Ali (Khattak)
Add a class to represent 'model' node under domain/cpu. --- libvirt-gconfig/Makefile.am| 2 + libvirt-gconfig/libvirt-gconfig-domain-cpu-model.c | 75 ++ libvirt-gconfig/libvirt-gconfig-domain-cpu-model.h | 68 libvirt-gconfig/libvi