Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

Hey, Still a couple of comments :( On Wed, Nov 25, 2015 at 09:46:58PM +, Zeeshan Ali (Khattak) wrote: > diff --git a/libvirt-gobject/libvirt-gobject-input-stream.c > b/libvirt-gobject/libvirt-gobject-input-stream.c > index ff1a70c..8ef60d6 100644 > ---

Re: [libvirt] [libvirt-glib v5] gobject: Port to GTask API

On Thu, Nov 26, 2015 at 10:20 AM, Christophe Fergeau wrote: > Hey, > > Still a couple of comments :( Fixed and pushed. Thanks for reviews. -- Regards, Zeeshan Ali (Khattak) Befriend GNOME: http://www.gnome.org/friends/ --

[libvirt] [libvirt-glib v5] gobject: Port to GTask API

Drop usage of deprecated GSimpleAsyncResult API. --- v5: * Plug some GError leaks. * Drop StoragePoolBuildData in favour of GUINT_TO_POINTER/GPOINTER_TO_UINT. * Don't unref GTask before using it later in idle callback. libvirt-gobject/libvirt-gobject-domain.c| 290