Re: [libvirt] [libvirt-go PATCH 3/3] Enforce new flags types in DomainSaveImageGetXMLDesc and GetXMLDesc

2019-02-22 Thread Eric Blake
On 2/22/19 9:32 AM, Erik Skultety wrote: > This breaks API compatibility! Recently libvirt introduced 2 new > separate flag enums in order to stop recycling the old virDomainXMLFlags > since 2/3 flags were discouraged to use. While it's fine for libvirt > to introduce such a change since it uses

[libvirt] [libvirt-go PATCH 3/3] Enforce new flags types in DomainSaveImageGetXMLDesc and GetXMLDesc

2019-02-22 Thread Erik Skultety
This breaks API compatibility! Recently libvirt introduced 2 new separate flag enums in order to stop recycling the old virDomainXMLFlags since 2/3 flags were discouraged to use. While it's fine for libvirt to introduce such a change since it uses plain 'int' for flags, not so much for the Go