Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-27 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Fri, Oct 24, 2014 at 09:29:29AM -0600, Jim Fehlig wrote: > >> Right. IMO, sleeping in this test is not papering over a bug. The bug >> is attempting to hotplug/hotunplug devices before the guest has an >> opportunity to boot. As currently written, the attempt to

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 09:29:29AM -0600, Jim Fehlig wrote: > Daniel P. Berrange wrote: > > On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: > > > >> Eric Blake wrote: > >> > >>> On 10/23/2014 03:21 PM, Jim Fehlig wrote: > >>> > >>> > This patch fixes a few issues

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Jim Fehlig
Daniel P. Berrange wrote: > On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: > >> Eric Blake wrote: >> >>> On 10/23/2014 03:21 PM, Jim Fehlig wrote: >>> >>> This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, t

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Daniel P. Berrange
On Fri, Oct 24, 2014 at 09:15:42AM -0600, Jim Fehlig wrote: > Eric Blake wrote: > > On 10/23/2014 03:21 PM, Jim Fehlig wrote: > > > >> This patch fixes a few issues noted while enabling the TCK PCI device > >> hotplug tests. > >> > >> First, the call to node device dettach function misses parame

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-24 Thread Jim Fehlig
Eric Blake wrote: > On 10/23/2014 03:21 PM, Jim Fehlig wrote: > >> This patch fixes a few issues noted while enabling the TCK PCI device >> hotplug tests. >> >> First, the call to node device dettach function misses parameters, resulting >> in the following failure >> >> Failed test 'detached d

Re: [libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-23 Thread Eric Blake
On 10/23/2014 03:21 PM, Jim Fehlig wrote: > This patch fixes a few issues noted while enabling the TCK PCI device > hotplug tests. > > First, the call to node device dettach function misses parameters, resulting > in the following failure > > Failed test 'detached device from host OS' > at /usr

[libvirt] [libvirt-tck PATCH] Fix PCI device hotplug tests

2014-10-23 Thread Jim Fehlig
This patch fixes a few issues noted while enabling the TCK PCI device hotplug tests. First, the call to node device dettach function misses parameters, resulting in the following failure Failed test 'detached device from host OS' at /usr/share/libvirt-tck/tests/domain/250-pci-host-hotplug.t lin