Re: [libvirt] [libvirt PATCH] support continue/return targets in nwfilter

2011-10-20 Thread Eric Blake
On 10/19/2011 01:51 AM, Daniel P. Berrange wrote: On Tue, Oct 18, 2011 at 12:55:25PM -0700, David L Stevens wrote: This patch adds support for continue and return actions in filter rules. Signed-off-by: David L Stevensdlstev...@us.ibm.com ACK Though it'd be good to update

Re: [libvirt] [libvirt PATCH] support continue/return targets in nwfilter

2011-10-20 Thread David Stevens
Eric, Thanks -- looks good to me. return is useful for doing multiple chains on one packet -- drop if it isn't acceptable and return to do further checks in other chains for the acceptable ones. The current fixed-set of protocol chains are mutually exclusive which

Re: [libvirt] [libvirt PATCH] support continue/return targets in nwfilter

2011-10-19 Thread Daniel P. Berrange
On Tue, Oct 18, 2011 at 12:55:25PM -0700, David L Stevens wrote: This patch adds support for continue and return actions in filter rules. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 04bfa22..3e28806

[libvirt] [libvirt PATCH] support continue/return targets in nwfilter

2011-10-18 Thread David L Stevens
This patch adds support for continue and return actions in filter rules. Signed-off-by: David L Stevens dlstev...@us.ibm.com diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 04bfa22..3e28806 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@