[libvirt] [libvirt PATCH v2] Introduce virDomainChrDefNew()

2011-04-14 Thread Michal Novotny
Make: passed Make check: passed Make syntax-check: passed Hi, this is the commit to introduce the function to create new character device definition for the domain as advised by Cole Robinson . The function is used on the relevant places and also new tests has been added. Michal Signed-off-by:

Re: [libvirt] [libvirt PATCH v2] Introduce virDomainChrDefNew()

2011-04-14 Thread Cole Robinson
On 04/14/2011 10:50 AM, Michal Novotny wrote: > Make: passed > Make check: passed > Make syntax-check: passed > > Hi, > this is the commit to introduce the function to create new character > device definition for the domain as advised by Cole Robinson > . > > The function is used on the relevant

Re: [libvirt] [libvirt PATCH v2] Introduce virDomainChrDefNew()

2011-04-14 Thread Michal Novotny
[snip] I've fixed those OOMErrors and the whitespace already for v3 however I won't send the v3 of the patch until I get reply to this since some other approach may have to be chosen for the port = 0 things. comments inline ... > Hmm, why exactly are these port = 0 changes needed? Were they brea

Re: [libvirt] [libvirt PATCH v2] Introduce virDomainChrDefNew()

2011-04-14 Thread Cole Robinson
On 04/14/2011 11:42 AM, Michal Novotny wrote: > [snip] > > I've fixed those OOMErrors and the whitespace already for v3 however I > won't send the v3 of the patch until I get reply to this since some > other approach may have to be chosen for the port = 0 things. comments > inline ... > > >> Hmm