Re: [libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

2018-04-15 Thread Ján Tomko
On Thu, Apr 12, 2018 at 10:41:03AM +0200, Andrea Bolognani wrote: On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +

Re: [libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

2018-04-12 Thread Andrea Bolognani
On Thu, 2018-04-12 at 11:54 +0200, Ján Tomko wrote: > > I just realized that all of these should have a qemu: prefix in > > the first line of the commit message. Before pushing, can you > > please make sure they do? > > I rarely use prefixes, they take up valuable space in the commit > summary. >

Re: [libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

2018-04-12 Thread Andrea Bolognani
On Mon, 2018-04-09 at 17:20 +0200, Ján Tomko wrote: > Implied by QEMU >= 1.2.0. > > Signed-off-by: Ján Tomko > --- > src/qemu/qemu_capabilities.c | 1 - > src/qemu/qemu_capabilities.h | 2 +- > src/qemu/qemu_command.c

[libvirt] [libvirt PATCH v2 13/44] Deprecate QEMU_CAPS_DRIVE_SERIAL

2018-04-09 Thread Ján Tomko
Implied by QEMU >= 1.2.0. Signed-off-by: Ján Tomko --- src/qemu/qemu_capabilities.c | 1 - src/qemu/qemu_capabilities.h | 2 +- src/qemu/qemu_command.c | 20 tests/qemucapabilitiesdata/caps_1.5.3.