Re: [libvirt] [python PATCH 1/5] generator: enum: Don't sort enums by names

2014-08-29 Thread Pavel Hrdina
On 08/28/2014 06:38 PM, Eric Blake wrote: On 08/28/2014 10:32 AM, Peter Krempa wrote: Setting OCDs aside, sorting enums breaks if the definition contains links to other enums defined in the libvirt header before. Let the generator generate it in the natural order. --- generator.py | 2 --

[libvirt] [python PATCH 1/5] generator: enum: Don't sort enums by names

2014-08-28 Thread Peter Krempa
Setting OCDs aside, sorting enums breaks if the definition contains links to other enums defined in the libvirt header before. Let the generator generate it in the natural order. --- generator.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/generator.py b/generator.py index

Re: [libvirt] [python PATCH 1/5] generator: enum: Don't sort enums by names

2014-08-28 Thread Eric Blake
On 08/28/2014 10:32 AM, Peter Krempa wrote: Setting OCDs aside, sorting enums breaks if the definition contains links to other enums defined in the libvirt header before. Let the generator generate it in the natural order. --- generator.py | 2 -- 1 file changed, 2 deletions(-) ACK. But I