Re: [libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

2019-11-23 Thread Chris Lalancette
On Fri, Nov 22, 2019 at 7:53 PM Cole Robinson wrote: > > CCing clalance who is the primary ruby-libvirt maintainer, but if he > > doesn't get to it by next week then I'll figure out how to build test > > it, and push > > > > I've pushed this now > Sorry I missed this. Thanks for the patch, and

Re: [libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

2019-11-22 Thread Cole Robinson
On 11/14/19 4:57 PM, Cole Robinson wrote: > On 10/22/19 11:47 AM, Stefano Garzarella wrote: >> ruby_libvirt_value_to_int() returns 0 if the optional value is >> not defined, but in node_cpu_stats() and node_memory_stats() >> the default value of cpuNum and cellNum is -1. >> > > I know nothing

Re: [libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

2019-11-15 Thread Stefano Garzarella
On Thu, Nov 14, 2019 at 04:57:49PM -0500, Cole Robinson wrote: > On 10/22/19 11:47 AM, Stefano Garzarella wrote: > > ruby_libvirt_value_to_int() returns 0 if the optional value is > > not defined, but in node_cpu_stats() and node_memory_stats() > > the default value of cpuNum and cellNum is -1. >

Re: [libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

2019-11-14 Thread Cole Robinson
On 10/22/19 11:47 AM, Stefano Garzarella wrote: > ruby_libvirt_value_to_int() returns 0 if the optional value is > not defined, but in node_cpu_stats() and node_memory_stats() > the default value of cpuNum and cellNum is -1. > I know nothing about ruby or the libvirt bindings, but what you

[libvirt] [ruby PATCH] Fix default values for node_cpu_stats() and node_memory_stats()

2019-10-22 Thread Stefano Garzarella
ruby_libvirt_value_to_int() returns 0 if the optional value is not defined, but in node_cpu_stats() and node_memory_stats() the default value of cpuNum and cellNum is -1. Reported-by: Charlie Smurthwaite Signed-off-by: Stefano Garzarella --- ext/libvirt/connect.c | 14 -- 1 file