Re: [libvirt] [snmp PATCH 1/2] Replace U64 with struct counter64 to fix build

2018-03-22 Thread Michael Corcoran
On Wed, 2018-03-21 at 17:46 +0100, Michal Privoznik wrote: > > ACK. Although you've missed some other occurrences. I'm fixing them too. > > Michal Thanks very much. As to the slightly weird U64(struct counter64) in comments... I copy-pasted that from what mib2c generated with the patched .m2d.

Re: [libvirt] [snmp PATCH 1/2] Replace U64 with struct counter64 to fix build

2018-03-21 Thread Michal Privoznik
On 03/20/2018 09:41 AM, Michael Corcoran wrote: > Upstream net-snmp removed the U64 typedef in 2016 as it clashed with a > name in Perl, thus all usages of U64 must be replaced by struct counter64 to > compile against recent versions of net-snmp. > > The replacements were made by hand, while

[libvirt] [snmp PATCH 1/2] Replace U64 with struct counter64 to fix build

2018-03-20 Thread Michael Corcoran
Upstream net-snmp removed the U64 typedef in 2016 as it clashed with a name in Perl, thus all usages of U64 must be replaced by struct counter64 to compile against recent versions of net-snmp. The replacements were made by hand, while referencing diff with new source generated by the mib2c tool.