Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-15 Thread Laine Stump
On 2/15/19 10:51 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 02:56:31PM +, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: On Mon,

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-15 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 02:56:31PM +, Daniel P. Berrangé wrote: > On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: > > On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: > > > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > > > > On Mon, Feb 11, 2019, 5:50 AM Daniel P.

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Laine Stump
On 2/11/19 9:56 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé wrote: On Sat, Feb 09, 2019

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 09:51:09AM -0500, Laine Stump wrote: > On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: > > On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > > > On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé > > > wrote: > > > > > > > On Sat, Feb 09, 2019 at 02:03:05PM

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Laine Stump
On 2/11/19 6:11 AM, Daniel P. Berrangé wrote: On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé wrote: On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote: Since this test (050-apply-verify-host.t), we can't use a regexp in

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
On Mon, Feb 11, 2019 at 06:07:40AM -0500, Laine Stump wrote: > On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé > wrote: > > > On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote: > > > Since this test (050-apply-verify-host.t), we can't use a regexp in > > > the string to be compared.

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Laine Stump
On Mon, Feb 11, 2019, 5:50 AM Daniel P. Berrangé wrote: > On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote: > > Since this test (050-apply-verify-host.t), we can't use a regexp in > > the string to be compared. The fix method that leads to the least > > changes is to use sed to remove

Re: [libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-11 Thread Daniel P . Berrangé
On Sat, Feb 09, 2019 at 02:03:05PM -0500, Laine Stump wrote: > Since this test (050-apply-verify-host.t), we can't use a regexp in > the string to be compared. The fix method that leads to the least > changes is to use sed to remove potential leading 0's. > > Signed-off-by: Laine Stump > --- >

[libvirt] [tck PATCH 5/4] nwfilter: account for more leading 0's in MAC addresses in ebtables output

2019-02-09 Thread Laine Stump
Since this test (050-apply-verify-host.t), we can't use a regexp in the string to be compared. The fix method that leads to the least changes is to use sed to remove potential leading 0's. Signed-off-by: Laine Stump --- (These changes fix *almost* all failures in