[libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Jason Krieg
Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 *opts_seen moved into the != VSH_OT_ARGV if statement so now opts_seen is only set if not VSH_OT_ARGV see attached fix Regards Jason diff -Nurp

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Eric Blake
On 09/21/2011 06:18 AM, Jason Krieg wrote: Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 *opts_seen moved into the != VSH_OT_ARGV if statement so now opts_seen is only set if not VSH_OT_ARGV diff -Nurp

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Daniel P. Berrange
On Wed, Sep 21, 2011 at 06:28:26AM -0600, Eric Blake wrote: On 09/21/2011 06:18 AM, Jason Krieg wrote: Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 *opts_seen moved into the != VSH_OT_ARGV if statement

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Osier Yang
于 2011年09月21日 20:28, Eric Blake 写道: On 09/21/2011 06:18 AM, Jason Krieg wrote: Hi, the virsh qemu-monitor-command is not working with libvirt 0.9.5 with git commit 85d2810823a31634b12145d6c196930b40425370 So does command send-key. *opts_seen moved into the != VSH_OT_ARGV if statement so

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Eric Blake
On 09/21/2011 06:28 AM, Eric Blake wrote: +++ libvirt-0.9.5.new/tools/virsh.c 2011-09-21 13:56:17.0 +0200 @@ -13916,8 +13916,8 @@ vshCmddefGetData(const vshCmdDef *cmd, u opt =cmd-opts[i]; if (opt-type != VSH_OT_ARGV) { *opts_need_arg= ~(1 i); - *opts_seen |= 1 i; } + *opts_seen |= 1 i;

Re: [libvirt] virsh qemu-monitor-command broken with 0.9.5

2011-09-21 Thread Jason Krieg
On 09/21/2011 05:00 PM, Eric Blake wrote: On 09/21/2011 06:28 AM, Eric Blake wrote: +++ libvirt-0.9.5.new/tools/virsh.c 2011-09-21 13:56:17.0 +0200 @@ -13916,8 +13916,8 @@ vshCmddefGetData(const vshCmdDef *cmd, u opt =cmd-opts[i]; if (opt-type != VSH_OT_ARGV) { *opts_need_arg= ~(1 i); -