Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-07 Thread Guido Günther
On Mon, Jan 06, 2014 at 10:59:31AM +0100, Christophe Fergeau wrote: Hey, On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: It's been a while since the last time I've written something for libivrt-glib. So just my two cents: I'd say go with new class esp. if there's a

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-07 Thread Christophe Fergeau
On Tue, Jan 07, 2014 at 11:21:22PM +0100, Guido Günther wrote: On Mon, Jan 06, 2014 at 10:59:31AM +0100, Christophe Fergeau wrote: Hey, On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: It's been a while since the last time I've written something for libivrt-glib. So

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-07 Thread Guido Günther
On Tue, Jan 07, 2014 at 11:54:57PM +0100, Christophe Fergeau wrote: On Tue, Jan 07, 2014 at 11:21:22PM +0100, Guido Günther wrote: On Mon, Jan 06, 2014 at 10:59:31AM +0100, Christophe Fergeau wrote: Hey, On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: It's been a

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-06 Thread Michal Privoznik
On 06.12.2013 12:13, Christophe Fergeau wrote: Hey, I wanted to add support in libvirt-gconfig for the 'discard' attribute of the disk driver node. If I follow the way the API is currently done, it would be an additional method to GVirConfigDomainDisk. However, there are quite a few

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-06 Thread Christophe Fergeau
Hey, On Mon, Jan 06, 2014 at 10:40:49AM +0100, Michal Privoznik wrote: It's been a while since the last time I've written something for libivrt-glib. So just my two cents: I'd say go with new class esp. if there's a chance for attributes to expand. Although, we still have to maintain the old

Re: [libvirt] Add GVirConfigDomainDiskDriver

2014-01-02 Thread Christophe Fergeau
Ping? Christophe On Fri, Dec 06, 2013 at 12:13:39PM +0100, Christophe Fergeau wrote: Hey, I wanted to add support in libvirt-gconfig for the 'discard' attribute of the disk driver node. If I follow the way the API is currently done, it would be an additional method to

[libvirt] Add GVirConfigDomainDiskDriver

2013-12-06 Thread Christophe Fergeau
Hey, I wanted to add support in libvirt-gconfig for the 'discard' attribute of the disk driver node. If I follow the way the API is currently done, it would be an additional method to GVirConfigDomainDisk. However, there are quite a few attributes attached to the disk driver node, so I felt it