Re: [libvirt] Bug: virsh edit broken on master

2019-11-18 Thread Daniel P . Berrangé
On Mon, Nov 18, 2019 at 05:12:23PM +0100, Bjoern Walk wrote: > Hey all, > > commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh > edit` (at least on S390): This change didn't request any access bits so the temp files are all being created with O_RDONLY. openat(AT_FDCWD,

Re: [libvirt] Bug: virsh edit broken on master

2019-11-18 Thread Ján Tomko
On Mon, Nov 18, 2019 at 05:12:23PM +0100, Bjoern Walk wrote: Hey all, commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh Oops, edit` (at least on S390): virsh # edit test error: write: /tmp/virshQ7SXB0.xml: failed to write to temporary file: Bad file descriptorx

[libvirt] Bug: virsh edit broken on master

2019-11-18 Thread Bjoern Walk
Hey all, commit 4ac47730: Use g_mkstemp_full instead of mkostemp(s) broke `virsh edit` (at least on S390): virsh # edit test error: write: /tmp/virshQ7SXB0.xml: failed to write to temporary file: Bad file descriptorx I didn't find out why, everything looks normal: # ls -l